kossebau added inline comments. INLINE COMMENTS
> kossebau wrote in statjob.h:181 > I wonder if this should not be rather a member of StatJob, instead of being > on generic KIO namespace level. > It feels unbalanced to have the enum being in the class, but a util flag set > not. Actually, this could be part of the StatJob::StatDetail enum, no? Having combinations of lfags in the enum itself (to be used as shortcuts) is usual practice and also should not conflict with Q_DECLARE_FLAGS, IIRC (would need to check). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
