bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> taglibextractor.cpp:105
>
> -void TagLibExtractor::readGenericProperties(const TagLib::PropertyMap
> &savedProperties, ExtractionResult* result)
> +void readGenericProperties(const TagLib::PropertyMap &savedProperties,
> ExtractionResult* result)
> {
This puts `readGenericProperties(...)` with external linkage in the global
namespace.
Put the private helpers in an anonymous namespace (and also include
`extractAudioProperties(...)` in it).
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D25516
To: astippich, #baloo, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2,
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
