astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibextractor.cpp:105
> This puts `readGenericProperties(...)` with external linkage in the global 
> namespace.
> 
> Put the private helpers in an anonymous namespace (and also include 
> `extractAudioProperties(...)` in it).

Urgh, that was the plan actually. I could swear I've done that.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25516

To: astippich, #baloo, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

Reply via email to