broulik added inline comments. INLINE COMMENTS
> dfaure wrote in desktopexecparser.cpp:356 > This blocks. > > I don't mind much myself, but I know some people had a mandate to remove as > many blocking calls as possible from KRun and related code. Or was that only > avoiding blocking I/O because of network mounts? [which this patch is all > about adding more of...]. @broulik ? Blocking IO is worse than blocking DBus, still not nice, especially given the "job"-like nature of `KRun` I would expect it to be fully async. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: alexde, broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns
