feverfew added a comment.
In D23384#577174 <https://phabricator.kde.org/D23384#577174>, @dfaure wrote: > For SMB shares I guess what can happen is that the URL doesn't have a username in it, but it still needs a password? IIRC there was no username in "old" samba (W95 <https://phabricator.kde.org/W95>, W98 <https://phabricator.kde.org/W98>, XP, ...?). > This might explain what you were saying about people having password problems even with empty userInfo() (which means username and password). > But we can hardly know, just by looking at a URL, if a password is needed... I guess most of time a password is actually needed? Maybe you're right after all, and we should always send SMB urls to kiofuse..... Dunno. @ngraham could you confirm if you have the credential issue with the current state of this patch. If you do, I'll simplify the logic seeming as there's no chance I can be "smart" about this here. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: alexde, broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns
