----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122048/#review74001 -----------------------------------------------------------
I really like this feature. However, I think that UI wise, it looks a bit unpolished. It adds two checkboxes with long texts, that even I, being a domain expert, need some thinking to understand. I wonder if we should offer these actions at all, or whether we should enable the features by default. They do seem useful, I can construct a use-case pretty easily, but we may get away without the UI options, still keeping the config keys, perhaps. Then wait until someone complains or reports unexpected behavior, and then rethink adding the options. Inline, a few niggles about naming when reading the code and trying to understand it, nothing really major. PowerDevilSettings.kcfg <https://git.reviewboard.kde.org/r/122048/#comment51401> Why not inhibitOnLidClose? Less negations make it more readable. (I had to think about what it meant.) daemon/actions/bundled/handlebuttonevents.h <https://git.reviewboard.kde.org/r/122048/#comment51402> Off-hand, I don't understand what these vars ar e doing by reading their name. Would be nice if it was more clear for the next person to look at this code. Perhaps a comment? daemon/actions/bundled/handlebuttoneventsconfig.cpp <https://git.reviewboard.kde.org/r/122048/#comment51403> No super-happy with how these strings look like. Idea: Do not <suspend> when external monitor is connected As to the second option, is it clear that the lid close depends on power management being enabled? Do we need this option at all? (Both are open questions.) - Sebastian Kügler On Jan. 13, 2015, 11:16 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122048/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2015, 11:16 p.m.) > > > Review request for Solid, KDE Usability, Àlex Fiestas, and Daniel Vrátil. > > > Repository: powerdevil > > > Description > ------- > > Less sensational headline: Skip lid action when external monitor is connected. > > This brings the KScreen killer feature in the 4.x times back. Now you can > watch movies and safely close the lid again! > > The confusing "Never prevent an action on lid close" is also moved to the > main page since it only affects the lid action and is used nowhere else. I'm > not happy with the wording but "inhibition" is a difficult thing to describe > for the average user. > > > Diffs > ----- > > CMakeLists.txt 27f162c > PowerDevilSettings.kcfg 1bc7ce1 > daemon/CMakeLists.txt f1e6efb > daemon/actions/bundled/handlebuttonevents.h 8ea23f6 > daemon/actions/bundled/handlebuttonevents.cpp ac280f4 > daemon/actions/bundled/handlebuttoneventsconfig.h a55bca7 > daemon/actions/bundled/handlebuttoneventsconfig.cpp 92f0cef > kcmodule/global/GeneralPage.cpp 5d9ff10 > kcmodule/global/generalPage.ui 26204cb > > Diff: https://git.reviewboard.kde.org/r/122048/diff/ > > > Testing > ------- > > Laptop only, monitor option on -> Suspend > Laptop only, monitor option off -> Suspend > TV connected, monitor option on -> No action > TV connected, monitor option off -> Suspend > > PM enabled, inhibit option on -> Suspend > PM disabled, inhibit option on -> No suspend > PM enabled, inhibit option off -> Suspend > PM disabled, inhibit option off -> Suspend > > > File Attachments > ---------------- > > Config option > > https://git.reviewboard.kde.org/media/uploaded/files/2015/01/13/e0956548-0a0f-4c41-b3dd-68a5f17815a5__powerdevilstuff.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
