> On April 23, 2015, 1:32 p.m., Aleix Pol Gonzalez wrote: > > daemon/backends/upower/powerdevilupowerbackend.cpp, line 161 > > <https://git.reviewboard.kde.org/r/123475/diff/1/?file=362676#file362676line161> > > > > Is it fine to use exec() here?
no, I missed that one :-( - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123475/#review79375 ----------------------------------------------------------- On April 23, 2015, 1:05 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123475/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 1:05 p.m.) > > > Review request for Plasma, Solid and Kai Uwe Broulik. > > > Repository: powerdevil > > > Description > ------- > > KJob::exec is dangerous and caused freezes on my system. Thus this change > to remodel the interaction in an async way. > > > Diffs > ----- > > daemon/backends/upower/powerdevilupowerbackend.h > 1c4dd592f0a3cb07b9821c7f82c89517d599635a > daemon/backends/upower/powerdevilupowerbackend.cpp > 87b9cc7b7db1b6a6f5b31263cd3832715c497328 > > Diff: https://git.reviewboard.kde.org/r/123475/diff/ > > > Testing > ------- > > kded5 no longer freezes. But I'm not sure whether the init gets finished: is > there a way to easily verify whether the module loaded completely? > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
