> On Mai 10, 2015, 5:08 nachm., Kai Uwe Broulik wrote: > > daemon/backends/upower/powerdevilupowerbackend.cpp, line 175 > > <https://git.reviewboard.kde.org/r/123475/diff/2/?file=362775#file362775line175> > > > > Somehow that code path is never executed making init stuck when XRandR > > is not supported, however, I don't know why that is. The brightnessmaxjob > > works fine but the syspath thing doesn't. > > Martin Gräßlin wrote: > any ideas how we can test it? Was it working before at all?
Just return false in XRandrBrightness::isSupported() to force it into the brightness helper code path. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123475/#review80178 ----------------------------------------------------------- On April 24, 2015, 6:29 vorm., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123475/ > ----------------------------------------------------------- > > (Updated April 24, 2015, 6:29 vorm.) > > > Review request for Solid and Kai Uwe Broulik. > > > Repository: powerdevil > > > Description > ------- > > KJob::exec is dangerous and caused freezes on my system. Thus this change > to remodel the interaction in an async way. > > > Diffs > ----- > > daemon/backends/upower/powerdevilupowerbackend.h > 1c4dd592f0a3cb07b9821c7f82c89517d599635a > daemon/backends/upower/powerdevilupowerbackend.cpp > 87b9cc7b7db1b6a6f5b31263cd3832715c497328 > > Diff: https://git.reviewboard.kde.org/r/123475/diff/ > > > Testing > ------- > > kded5 no longer freezes. But I'm not sure whether the init gets finished: is > there a way to easily verify whether the module loaded completely? > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel
