-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100689/
-----------------------------------------------------------

(Updated March 5, 2011, 8:56 a.m.)


Review request for Telepathy.


Changes
-------

Okay, most of the issues appear to be fixed (either by freinhard when he wrote 
the skype plugin, or you when you fixed my conflicts :) 

I removed the debugging code to print out a list of supported parameters from 
both my plugins. If I have time I'd like to add it to the constructor of 
AbstractAccountParametersWidget, as it was rather useful. 

I pushed the changes back to my clone, this time in branch aim.
http://quickgit.kde.org/?p=clones/telepathy-accounts-kcm-plugins/fernando/main.git&a=shortlog&h=refs/heads/aim


Summary
-------

I created a AIM plugin, with basic and advanced options in one go this time.

It's in my personal clone
http://quickgit.kde.org/?p=clones/telepathy-accounts-kcm-plugins/fernando/main.git&a=shortlog&h=refs/heads/aol-plugin-build

(branch called 'aol-plugin-build')


Diffs (updated)
-----

  haze/aim-main-options-widget.cpp PRE-CREATION 
  haze/yahoo-main-options-widget.cpp 8beec3c 

Diff: http://git.reviewboard.kde.org/r/100689/diff


Testing
-------

Edited options and made sure they were reflected in Empathy.


Thanks,

Lasath

_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy

Reply via email to