----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100689/#review2944 -----------------------------------------------------------
Ship it! Seems ok to me. There's one thing to sort out with git first (editing the yahoo options) before pushing. haze/haze-account-ui-plugin.cpp <http://git.reviewboard.kde.org/r/100689/#comment2515> Not sure if this is just reviewboard showing it wrong, but check this bracket is in the right place. haze/yahoo-main-options-widget.cpp <http://git.reviewboard.kde.org/r/100689/#comment2516> don't edit yahoo-main-options-widget when adding yours! - David On April 28, 2011, 2:46 p.m., Lasath Fernando wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100689/ > ----------------------------------------------------------- > > (Updated April 28, 2011, 2:46 p.m.) > > > Review request for Telepathy. > > > Summary > ------- > > I created a AIM plugin, with basic and advanced options in one go this time. > > It's in my personal clone > http://quickgit.kde.org/?p=clones/telepathy-accounts-kcm-plugins/fernando/main.git&a=shortlog&h=refs/heads/aol-plugin-build > > (branch called 'aol-plugin-build') > > > Diffs > ----- > > haze/CMakeLists.txt a998a65 > haze/aim-main-options-widget.h PRE-CREATION > haze/aim-main-options-widget.cpp PRE-CREATION > haze/aim-main-options-widget.ui PRE-CREATION > haze/aim-server-settings-widget.h PRE-CREATION > haze/aim-server-settings-widget.cpp PRE-CREATION > haze/aim-server-settings-widget.ui PRE-CREATION > haze/haze-account-ui-plugin.cpp 4854636 > haze/haze-aim-account.h PRE-CREATION > haze/haze-aim-account.cpp PRE-CREATION > haze/yahoo-main-options-widget.cpp 108a023 > > Diff: http://git.reviewboard.kde.org/r/100689/diff > > > Testing > ------- > > Edited options and made sure they were reflected in Empathy. > > > Thanks, > > Lasath > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
