----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102081/#review5217 -----------------------------------------------------------
See the comments inline below. Also, I think you forgot to add the everyone-person-set-model.[h|cpp] to the diff when you uploaded it, as they don't seem to be here. src/declarative/CMakeLists.txt <http://git.reviewboard.kde.org/r/102081/#comment4727> This file should be part of libktelepathy, and then declarativeplugins should link against libktelepathy, rather than compiling this source file in again separately. src/declarative/CMakeLists.txt <http://git.reviewboard.kde.org/r/102081/#comment4723> Use the KDE-way of doing this stuff with CMake (see the src/CMakeLists.txt for example). Also, try and keep the code style consistent with the other CMakeLists.txt files in telepathy-kde, just because it makes things easier to read/modify/move around in future. Consistent code-style is really helpful for reading the code. src/declarative/declarativeplugins.h <http://git.reviewboard.kde.org/r/102081/#comment4725> Why is this file not (C) Francesco Nwokeka if you wrote it? Did someone from Collabora actually write this code? src/declarative/declarativeplugins.h <http://git.reviewboard.kde.org/r/102081/#comment4726> I'm nitpicking, but you should namespace this #define like all the other files in the repo do. src/declarative/declarativeplugins.cpp <http://git.reviewboard.kde.org/r/102081/#comment4728> Again, did someone from Collabora write this code, or did you? src/declarative/declarativeplugins.cpp <http://git.reviewboard.kde.org/r/102081/#comment4729> Shouldn't this be #include <QtDeclarative/QDeclarative> ? - George On July 25, 2011, 12:12 p.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102081/ > ----------------------------------------------------------- > > (Updated July 25, 2011, 12:12 p.m.) > > > Review request for Telepathy, George Goldberg and David Edmundson. > > > Summary > ------- > > A patch to enable reading info from the nepomuk model via QML > > > Diffs > ----- > > CMakeLists.txt 0a58700 > src/CMakeLists.txt b0cf53b > src/declarative/CMakeLists.txt PRE-CREATION > src/declarative/declarativeplugins.h PRE-CREATION > src/declarative/declarativeplugins.cpp PRE-CREATION > src/declarative/qmldir PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/102081/diff > > > Testing > ------- > > This patch works with basic contact list plasmoid in the works in my scratch > repo. > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
