> On July 29, 2011, 2:39 p.m., George Goldberg wrote: > > See the comments inline below. Also, I think you forgot to add the > > everyone-person-set-model.[h|cpp] to the diff when you uploaded it, as they > > don't seem to be here.
Yes, I forgot to "git add" them. Will be in next diff > On July 29, 2011, 2:39 p.m., George Goldberg wrote: > > src/declarative/declarativeplugins.h, line 4 > > <http://git.reviewboard.kde.org/r/102081/diff/2/?file=29776#file29776line4> > > > > Why is this file not (C) Francesco Nwokeka if you wrote it? Did someone > > from Collabora actually write this code? Thought I was supposed to maintain the license of other files in the lib. Fixing it > On July 29, 2011, 2:39 p.m., George Goldberg wrote: > > src/declarative/declarativeplugins.cpp, line 26 > > <http://git.reviewboard.kde.org/r/102081/diff/2/?file=29777#file29777line26> > > > > Shouldn't this be #include <QtDeclarative/QDeclarative> ? <QtDeclarative> > On July 29, 2011, 2:39 p.m., George Goldberg wrote: > > src/declarative/declarativeplugins.h, line 23 > > <http://git.reviewboard.kde.org/r/102081/diff/2/?file=29776#file29776line23> > > > > I'm nitpicking, but you should namespace this #define like all the > > other files in the repo do. Fixed > On July 29, 2011, 2:39 p.m., George Goldberg wrote: > > src/declarative/CMakeLists.txt, line 14 > > <http://git.reviewboard.kde.org/r/102081/diff/2/?file=29775#file29775line14> > > > > Use the KDE-way of doing this stuff with CMake (see the > > src/CMakeLists.txt for example). Also, try and keep the code style > > consistent with the other CMakeLists.txt files in telepathy-kde, just > > because it makes things easier to read/modify/move around in future. > > Consistent code-style is really helpful for reading the code. I followed the way the guys @plasma do things. They use this to import their graphical widgets to QML. You can find it in their CMakeLists.txt file under: "kde-runtime/plasma/declarativeimports/graphicswidgets" - Francesco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102081/#review5217 ----------------------------------------------------------- On July 25, 2011, 12:12 p.m., Francesco Nwokeka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102081/ > ----------------------------------------------------------- > > (Updated July 25, 2011, 12:12 p.m.) > > > Review request for Telepathy, George Goldberg and David Edmundson. > > > Summary > ------- > > A patch to enable reading info from the nepomuk model via QML > > > Diffs > ----- > > CMakeLists.txt 0a58700 > src/CMakeLists.txt b0cf53b > src/declarative/CMakeLists.txt PRE-CREATION > src/declarative/declarativeplugins.h PRE-CREATION > src/declarative/declarativeplugins.cpp PRE-CREATION > src/declarative/qmldir PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/102081/diff > > > Testing > ------- > > This patch works with basic contact list plasmoid in the works in my scratch > repo. > > > Thanks, > > Francesco > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
