----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104407/#review12001 -----------------------------------------------------------
The patch does not apply correctly, please rebase it on latest master and resubmit app/chat-window.h <http://git.reviewboard.kde.org/r/104407/#comment9474> Align this with the others and remove one * at the end ( "*/" instead of "**/" ) app/chat-window.h <http://git.reviewboard.kde.org/r/104407/#comment9475> Same app/chat-window.h <http://git.reviewboard.kde.org/r/104407/#comment9476> Use doxygen style /** Comment */ here as well - Daniele Elmo Domenichelli On March 29, 2012, 11:46 p.m., Ahmed Ibrahim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104407/ > ----------------------------------------------------------- > > (Updated March 29, 2012, 11:46 p.m.) > > > Review request for Telepathy and Daniele Elmo Domenichelli. > > > Description > ------- > > Added Block/Unblock contact button to the KActionCollection of the > ktp-text-ui. > Added also code that will help in displaying blocking/unblocking actions to > the user in the ChatView. > > > This addresses bug 292402. > http://bugs.kde.org/show_bug.cgi?id=292402 > > > Diffs > ----- > > app/chat-window.h 8ee4463 > app/chat-window.cpp 75dd968 > app/chatwindow.rc f65fbd1 > app/main.cpp d76ce04 > lib/channel-contact-model.h 41d5d84 > lib/channel-contact-model.cpp d731322 > lib/chat-widget.h e1efbbb > lib/chat-widget.cpp bb1f5ef > > Diff: http://git.reviewboard.kde.org/r/104407/diff/ > > > Testing > ------- > > Blocked a contact and found that is blocked in another IM client and had > other opened tabs and the button was changing according to the user's block > state > > > Thanks, > > Ahmed Ibrahim > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
