> On March 30, 2012, 3:44 p.m., Daniele Elmo Domenichelli wrote: > > Looks good to me, except that you didn't fix Martin issue about > > KDualAction, so I'd say fix that as well or if Martin thinks it's ok he > > will give you the "ship it"
I'm ok with it because you'd have to have pretty much the same slot, with "if (state == active) ...", so it's fine. Ship it from me. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104407/#review12029 ----------------------------------------------------------- On March 30, 2012, 1:30 p.m., Ahmed Ibrahim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104407/ > ----------------------------------------------------------- > > (Updated March 30, 2012, 1:30 p.m.) > > > Review request for Telepathy and Daniele Elmo Domenichelli. > > > Description > ------- > > Added Block/Unblock contact button to the KActionCollection of the > ktp-text-ui. > Added also code that will help in displaying blocking/unblocking actions to > the user in the ChatView. > > > This addresses bug 292402. > http://bugs.kde.org/show_bug.cgi?id=292402 > > > Diffs > ----- > > app/chat-window.h fd81141 > app/chat-window.cpp bd4fc35 > app/chatwindow.rc ac5a259 > app/main.cpp d76ce04 > lib/channel-contact-model.h 41d5d84 > lib/channel-contact-model.cpp d731322 > lib/chat-widget.h 10de317 > lib/chat-widget.cpp 0a0b5db > > Diff: http://git.reviewboard.kde.org/r/104407/diff/ > > > Testing > ------- > > Blocked a contact and found that is blocked in another IM client and had > other opened tabs and the button was changing according to the user's block > state > > > Thanks, > > Ahmed Ibrahim > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
