----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105813/#review16992 -----------------------------------------------------------
Ship it! Much better now. It's a bit unclear how it behaves if there are multiple clients, but this is not a realistic scenario anyway. One other thing I just noticed (but don't hold this commit for this) is that if a client quits without stopping music first (i.e. the service gets unregistered), you may want to change presence back. - George Kiagiadakis On Aug. 6, 2012, 9:13 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105813/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2012, 9:13 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > I reworked the kded module to use async dbus calls. Now when it detects a > player, it queries for all its properties (to save some roundtrips) and if it > finds the player is playing, it sets the song info as the presence. > > > Diffs > ----- > > telepathy-mpris.h de45cec > telepathy-mpris.cpp 8386dd9 > > Diff: http://git.reviewboard.kde.org/r/105813/diff/ > > > Testing > ------- > > Tested with clementine. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
