> On Aug. 6, 2012, 7:08 p.m., George Kiagiadakis wrote: > > Much better now. It's a bit unclear how it behaves if there are multiple > > clients, but this is not a realistic scenario anyway. One other thing I > > just noticed (but don't hold this commit for this) is that if a client > > quits without stopping music first (i.e. the service gets unregistered), > > you may want to change presence back. > > Martin Klapetek wrote: > > It's a bit unclear how it behaves if there are multiple clients > > It should be whichever player sends the Metadata last, will "win". > Unfortunately Amarok seems retarted, because it sends with every manual track > change the "PlaybackStatus=Stopped" signal first, which disables the plugin > as it listens to that signal. This makes it effectively unusable with Amarok, > but also JuK. Works perfectly fine with Clementine. > > So the question is - should we deactivate this presence when you stop the > playback (like it is now) or just leave it on the "Now playing..." and keep > waiting for the playback status to change until the user changes the presence > manually? > > > if a client quits without stopping music first, you may want to change > presence back > > I tested with Clementine and that one behaves correctly - before it > quits, it sends the "PlaybackStatus=Stopped" message, while Amarok just > quits. So we'll have to add a connection for the service being unregistered > and disable it then. I might try to fix amarok/report a bug.
Hmm, I didn't notice this. I don't think the plugin should be disabled when you stop playing. You may well want to stop the player without quitting it and start it again later. I think it should only be disabled when the player quits. When it just stops, you could just reset the presence. - George ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105813/#review16992 ----------------------------------------------------------- On Aug. 6, 2012, 9:13 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105813/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2012, 9:13 a.m.) > > > Review request for Telepathy. > > > Description > ------- > > I reworked the kded module to use async dbus calls. Now when it detects a > player, it queries for all its properties (to save some roundtrips) and if it > finds the player is playing, it sets the song info as the presence. > > > Diffs > ----- > > telepathy-mpris.h de45cec > telepathy-mpris.cpp 8386dd9 > > Diff: http://git.reviewboard.kde.org/r/105813/diff/ > > > Testing > ------- > > Tested with clementine. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
