----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106228/#review18067 -----------------------------------------------------------
TelepathyLoggerQt4/log-manager.cpp <http://git.reviewboard.kde.org/r/106228/#comment14307> don't do this. 1) Sync calls are bad 2) Tp has a special way of generating Dbus bindings, where you provide an XML file and it magically builds everything. This already exists in the TpLoggerQt. If you open (in your build folder) _gen/cli-logger.h you will find it actually has these calls. They should still be wrapped in the LogManager, just like you've done, but instead we should keep an instance of the auto generated LoggerInterface and use that. Also calls should be wrapped in Tp::PendingOperation so we get something like clearAccountHistory(account) { return Tp::PendingVoid(m_interface->ClearAccount(account->objectPath()), account); } For any other project this would be absolutely fine, but TpQt has their own special way, so we should follow that. I should have mentioned it in the bug, but I didn't think about it till now. - David Edmundson On Aug. 26, 2012, 11:10 p.m., Dan Vratil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106228/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2012, 11:10 p.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > Add three new methods to Tpl::LogManager to invoke telepathy-logger DBus > methods for clearing logs. > > > Diffs > ----- > > TelepathyLoggerQt4/log-manager.h c245965 > TelepathyLoggerQt4/log-manager.cpp e6acf40 > > Diff: http://git.reviewboard.kde.org/r/106228/diff/ > > > Testing > ------- > > Works, be careful :) > > > Thanks, > > Dan Vratil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
