> On Sept. 1, 2012, 4:52 a.m., David Edmundson wrote: > > Awkward question. I was looking in the source code to check something, > > doesn't all this exist in PendingLogger?
It does, but Tpl::PendingLogger is not part of public API and requires Tpl::Logger which is not public either. Providing the API in Tpl::LogManager (by calling Tpl::PendingLogger) seems more logical to me because clearing logs == log management and also because we can simplify some calls for users (see Tpl::LogManager::clearEntityHistory()). - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106228/#review18357 ----------------------------------------------------------- On Aug. 31, 2012, 10:45 p.m., Dan Vratil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106228/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2012, 10:45 p.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > Add three new methods to Tpl::LogManager to invoke telepathy-logger DBus > methods for clearing logs. > > > Diffs > ----- > > TelepathyLoggerQt4/log-manager.h c245965 > TelepathyLoggerQt4/log-manager.cpp e6acf40 > > Diff: http://git.reviewboard.kde.org/r/106228/diff/ > > > Testing > ------- > > Works, be careful :) > > > Thanks, > > Dan Vratil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
