----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109136/ -----------------------------------------------------------
Review request for Telepathy and David Edmundson. Description ------- This fixes some problems in the pinned contacts model: - Use KTp::ContactPtr instead of Tp::ContactPtr - Compare contact pointers instead of id's. Don't make sure that the account is the same. - Add comment explaining why we need to delay the dataChanged when a conversation state changes. Also use the proper index. This was inspired in a patch by David Diffs ----- KTp/Declarative/contact-pin.cpp 9ad3bcd KTp/Declarative/pinned-contacts-model.h 216c517 KTp/Declarative/pinned-contacts-model.cpp 0c2607c Diff: http://git.reviewboard.kde.org/r/109136/diff/ Testing ------- Thanks, Aleix Pol Gonzalez
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
