----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109136/#review28022 -----------------------------------------------------------
Ship it! KTp/Declarative/pinned-contacts-model.cpp <http://git.reviewboard.kde.org/r/109136/#comment20987> you don't need to qobject cast That goes for a few other places too KTp/Declarative/pinned-contacts-model.cpp <http://git.reviewboard.kde.org/r/109136/#comment20985> I thought we were going to stop using ->id() KTp/Declarative/pinned-contacts-model.cpp <http://git.reviewboard.kde.org/r/109136/#comment20986> don't use shadow variables, redeclaring idx in the same function. It's valid, but confusing to read. I suggest changing the first idx to sourceIdx - David Edmundson On Feb. 25, 2013, 4:28 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109136/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2013, 4:28 a.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > This fixes some problems in the pinned contacts model: > - Use KTp::ContactPtr instead of Tp::ContactPtr > - Compare contact pointers instead of id's. Don't make sure that the account > is the same. > - Add comment explaining why we need to delay the dataChanged when a > conversation state changes. Also use the proper index. > > This was inspired in a patch by David > > > Diffs > ----- > > KTp/Declarative/contact-pin.cpp 9ad3bcd > KTp/Declarative/pinned-contacts-model.h 216c517 > KTp/Declarative/pinned-contacts-model.cpp 0c2607c > > Diff: http://git.reviewboard.kde.org/r/109136/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
