----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109142/#review28041 -----------------------------------------------------------
I think the actions in 'View' menu are too long (+ they are actually sentences, and that's bad IMHO). But if other's are OK with it, ship it. main-widget.h <http://git.reviewboard.kde.org/r/109142/#comment20993> The variables should be all prefixed with "m_" to distinguish them from local variables. You should also set all the pointer to 0 in constructor. - Dan Vrátil On Feb. 25, 2013, 4:11 p.m., Roman Nazarenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109142/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2013, 4:11 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Added global menu support. > Menu is not appearing in main window, so it's tiny look is not broken. > I also moved actions for menu from MainWidget constructor to class private > scope, so they can be used from any method. > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=292396. > > http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=292396 > > > Diffs > ----- > > main-widget.h d14a669 > main-widget.cpp a3ea666 > > Diff: http://git.reviewboard.kde.org/r/109142/diff/ > > > Testing > ------- > > > Thanks, > > Roman Nazarenko > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
