> On Feb. 25, 2013, 4:19 p.m., Dan Vrátil wrote: > > main-widget.h, line 97 > > <http://git.reviewboard.kde.org/r/109142/diff/1/?file=115337#file115337line97> > > > > The variables should be all prefixed with "m_" to distinguish them from > > local variables. > > > > You should also set all the pointer to 0 in constructor.
Why should I? All my new pointers are initialized during construction, there's no need in null-initialization, I guess. - Roman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109142/#review28041 ----------------------------------------------------------- On Feb. 25, 2013, 3:11 p.m., Roman Nazarenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109142/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2013, 3:11 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Added global menu support. > Menu is not appearing in main window, so it's tiny look is not broken. > I also moved actions for menu from MainWidget constructor to class private > scope, so they can be used from any method. > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=292396. > > http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=292396 > > > Diffs > ----- > > main-widget.h d14a669 > main-widget.cpp a3ea666 > > Diff: http://git.reviewboard.kde.org/r/109142/diff/ > > > Testing > ------- > > > Thanks, > > Roman Nazarenko > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
