----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109134/#review28612 -----------------------------------------------------------
chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml <http://git.reviewboard.kde.org/r/109134/#comment21405> Shouldn't we just show the dialog in Component.onComplete? and in onVisibleChanged if it's not ready do nothing? - David Edmundson On March 5, 2013, 2:04 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109134/ > ----------------------------------------------------------- > > (Updated March 5, 2013, 2:04 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > Place the dialog by the plasmoid instead of 0,0 in case the button's delegate > hasn't been set up yet or there was a problem finding out the position. > > It's good because a dialog at 0,0 looks really odd. > > > Diffs > ----- > > chat/org.kde.ktp-chat/contents/ui/ConversationDelegate.qml de44494 > > Diff: http://git.reviewboard.kde.org/r/109134/diff/ > > > Testing > ------- > > just start a conversation from a pinned button and you'll see it looks > funny... > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
