> On Oct. 14, 2013, 12:29 p.m., Martin Klapetek wrote: > > kpeople/nepomuk-feeder/controller.cpp, line 80 > > <http://git.reviewboard.kde.org/r/113235/diff/1/?file=200993#file200993line80> > > > > This would however leave pimo:persons in place if I'm not mistaken, no? > > David Edmundson wrote: > I suppose, but pimo:Persons with no grounding occurrences. > > Martin Klapetek wrote: > Yes, so this leaves stale data in the database, which I think is a bit > wrong. I think adding pimo:persons to the query is easy-ish, so it can be > removed all at once. > > David Edmundson wrote: > I didn't want to do that because theoretically other people could be > using kpeople without KTp, we shouldn't break that. > > I could do it as a query afterwards to remove all pimo persons with no > grounding occurrence.. (which is a bit more work)? > > Martin Klapetek wrote: > > I didn't want to do that because theoretically other people could be > using kpeople without KTp, we shouldn't break that. > > Ah, that makes sense, though realistically there aren't that many > users...yet. > > > I could do it as a query afterwards to remove all pimo persons with no > grounding occurrence.. (which is a bit more work)? > > That could work, the hard part in "more work" is figuring out selecting > pimo:persons with no GOs, then it's just copy paste of the same block.
Lets be practical over here. The only ones using pimo:Persons are experimental things in nepomuk that have never been shipped (and probably never will be). So, IMO, you should go ahead and just delete them. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113235/#review41711 ----------------------------------------------------------- On Oct. 13, 2013, 6:24 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113235/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2013, 6:24 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > Wipe all KTp contacts when we release > > This is needed if we ship https://git.reviewboard.kde.org/r/112970/ for 0.7.0. > > > Diffs > ----- > > kpeople/nepomuk-feeder/controller.h b358c8e > kpeople/nepomuk-feeder/controller.cpp fa37b7e > > Diff: http://git.reviewboard.kde.org/r/113235/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
