> On Oct. 18, 2013, 11:28 a.m., Daniele E. Domenichelli wrote: > > It looks ok to me. > > > > Anyway 3 questions: > > > > 1) You start a KJob for each resource, perhaps starting just one KJob to > > delete all the resources would be more efficient since it already takes > > some time the first time you start the contact list, but I don't know if > > there is difference from nepomuk side. > > 2) You start the KJobs syncronously, maybe one single async kjob deleting > > all the resources would be better. > > 3) You never check the result values of the kjobs... I'm not sure if this > > might be useful, but maybe for debugging purpose it's worth printing > > something. > >
> 2) You start the KJobs syncronously, maybe one single async kjob deleting all > the resources would be better. I thought about it too, but you should not proceed with any other stuff unless the database is clean, so it's ok it's sync imho - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113235/#review41940 ----------------------------------------------------------- On Oct. 17, 2013, 9:52 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113235/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2013, 9:52 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > Wipe all KTp contacts when we release > > This is needed if we ship https://git.reviewboard.kde.org/r/112970/ for 0.7.0. > > > Diffs > ----- > > kpeople/nepomuk-feeder/controller.h b358c8e > kpeople/nepomuk-feeder/controller.cpp fa37b7e > > Diff: http://git.reviewboard.kde.org/r/113235/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
