> On March 23, 2014, 8:25 a.m., David Edmundson wrote: > > The description misses some parts: > > There's a new config option "Suppress Power Management when in ..." > > > > But this isn't shown in the diff. > > There's also some *'s added. > > > > I think maybe you've made 2 or more local commits in the kded-module and > > then only made a review for the last one?
EDIT: Just seen it's on top of 114574. You have even labelled it as such. I'm just blind. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114660/#review53783 ----------------------------------------------------------- On March 23, 2014, 5:55 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114660/ > ----------------------------------------------------------- > > (Updated March 23, 2014, 5:55 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-kded-module > > > Description > ------- > > Moves 3 connection state configurations into a single group box saving space. > > > Diffs > ----- > > config/telepathy-kded-config.cpp baaceff > config/telepathy-kded-config.ui 18f06f3 > > Diff: https://git.reviewboard.kde.org/r/114660/diff/ > > > Testing > ------- > > Compile, run. > > > File Attachments > ---------------- > > Connection states with keepAwake plugin > > https://git.reviewboard.kde.org/media/uploaded/files/2014/03/23/dcc51f7b-402e-4206-a860-af51974c5130__connectionstateswithkeepawake.png > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
