----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114660/#review53786 -----------------------------------------------------------
Combining the groupboxes for "restore" and "go offline when closing..." makes sense. I like it. File Attachment: Connection states with keepAwake plugin - connectionstateswithkeepawake.png <https://git.reviewboard.kde.org//r/114660/#fcomment197> I don't like this title. It sounds a bit technical. Maybe we can brainstorm something better. File Attachment: Connection states with keepAwake plugin - connectionstateswithkeepawake.png <https://git.reviewboard.kde.org//r/114660/#fcomment198> What's with the asterisk? That's not added in the previous diff either. Thomas, can you comment. - David Edmundson On March 23, 2014, 5:55 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114660/ > ----------------------------------------------------------- > > (Updated March 23, 2014, 5:55 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-kded-module > > > Description > ------- > > Moves 3 connection state configurations into a single group box saving space. > > > Diffs > ----- > > config/telepathy-kded-config.cpp baaceff > config/telepathy-kded-config.ui 18f06f3 > > Diff: https://git.reviewboard.kde.org/r/114660/diff/ > > > Testing > ------- > > Compile, run. > > > File Attachments > ---------------- > > Connection states with keepAwake plugin > > https://git.reviewboard.kde.org/media/uploaded/files/2014/03/23/dcc51f7b-402e-4206-a860-af51974c5130__connectionstateswithkeepawake.png > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
