> On April 28, 2014, 2:47 p.m., Thomas Pfeiffer wrote: > > Great that you are fixing this! > > From a usability perspective, the better way to show the message would be > > to display a KMessageWidget inside the chat window. That way the > > association between action and message is clear > > (http://techbase.kde.org/Projects/Usability/HIG/MessageWidget). > > Also, I'd change the message to "Your message cannot be sent because the > > account [accountname] is offline. Please try again when the account is > > online."
Additionally, we could just offer to bring the account online? - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117809/#review56743 ----------------------------------------------------------- On April 27, 2014, 11:26 p.m., Ahmed I. Khalil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117809/ > ----------------------------------------------------------- > > (Updated April 27, 2014, 11:26 p.m.) > > > Review request for Telepathy. > > > Bugs: 320385 > http://bugs.kde.org/show_bug.cgi?id=320385 > > > Repository: ktp-text-ui > > > Description > ------- > > Don't disable the input box when disconnected and the user sends a message a > status message is added saying "Your message was not sent because you are > offline" and the message box is not cleared. > > > Diffs > ----- > > lib/chat-widget.cpp c4f2ea5 > > Diff: https://git.reviewboard.kde.org/r/117809/diff/ > > > Testing > ------- > > Turned the connection offline, tried to send a message, a status message is > added as expected. Then turned the status to online the message is still > there and when pressed return the message is sent normally. > > > Thanks, > > Ahmed I. Khalil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
