----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117809/#review57134 -----------------------------------------------------------
One minor tweak I think will tidy the code. Otherwise +1 from me. lib/chat-widget.cpp <https://git.reviewboard.kde.org/r/117809/#comment39826> I'd rather we put the KMessageWidget into the .ui file. To do this you have to do a "PromotedWidget" which is a bit confusing the first time. I can walk you through it on IRC if you've not done it before. lib/chat-widget.cpp <https://git.reviewboard.kde.org/r/117809/#comment39828> ooh that's clever - David Edmundson On April 30, 2014, 10:45 p.m., Ahmed I. Khalil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117809/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 10:45 p.m.) > > > Review request for Telepathy. > > > Bugs: 320385 > http://bugs.kde.org/show_bug.cgi?id=320385 > > > Repository: ktp-text-ui > > > Description > ------- > > Don't disable the input box when disconnected and the user sends a message a > status message is added saying "Your message was not sent because you are > offline" and the message box is not cleared. > > > Diffs > ----- > > lib/chat-widget.h 028ece4 > lib/chat-widget.cpp c4f2ea5 > > Diff: https://git.reviewboard.kde.org/r/117809/diff/ > > > Testing > ------- > > Turned the connection offline, tried to send a message, a status message is > added as expected. Then turned the status to online the message is still > there and when pressed return the message is sent normally. > > > File Attachments > ---------------- > > Message Widget with "Switch Online" button > > https://git.reviewboard.kde.org/media/uploaded/files/2014/04/29/6139c0a4-c926-4c13-98cb-017fedab3155__Disconnected_with_online_button.png > Message Widget without the "Switch Online" button > > https://git.reviewboard.kde.org/media/uploaded/files/2014/04/29/9b46448b-3337-45ff-a336-df1f3ffe125e__Disconnected_with_no_online_button.png > > > Thanks, > > Ahmed I. Khalil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
