----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119085/#review61476 -----------------------------------------------------------
TelepathyLoggerQt4/log-manager.h <https://git.reviewboard.kde.org/r/119085/#comment42787> why not just a bool? TelepathyLoggerQt4/log-manager.cpp <https://git.reviewboard.kde.org/r/119085/#comment42788> set your editor up to trim whitespace (the red square in your diff indicates a space) TelepathyLoggerQt4/log-manager.cpp <https://git.reviewboard.kde.org/r/119085/#comment42789> Tp account isn't a great variable name, as they are both teleapthy accounts. Maybe tpl (for telepathy logger) though I see you're just copying convention here. Up to you. - David Edmundson On July 2, 2014, 11:59 a.m., Marcin Ziemiński wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119085/ > ----------------------------------------------------------- > > (Updated July 2, 2014, 11:59 a.m.) > > > Review request for Telepathy. > > > Repository: telepathy-logger-qt > > > Description > ------- > > Added simple wrappers of functions available in the master branch of > telepathy-logger > > > Diffs > ----- > > TelepathyLoggerQt4/log-manager.h 60a0e8c > TelepathyLoggerQt4/log-manager.cpp 7aadc4d > > Diff: https://git.reviewboard.kde.org/r/119085/diff/ > > > Testing > ------- > > > Thanks, > > Marcin Ziemiński > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
