----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119085/ -----------------------------------------------------------
(Updated July 3, 2014, 8:06 p.m.) Review request for Telepathy. Changes ------- Added ifdef on version of telepathy-logger. Not sure if this solution is the right way, because I couldn't find anything else. Another approach I can see is doing the evaluation of __TPL_VERSION_DISABLE_LOGGING__ strictly in cmake files to provide only this definition. Then it could be also added to the related projects such as ktp-common-internals (#119086). Maybe simply bumping the version of telepathy-logger in CMakeLists is better? Repository: telepathy-logger-qt Description ------- Added simple wrappers of functions available in the master branch of telepathy-logger Diffs (updated) ----- cmake/modules/FindTelepathyLogger.cmake 19de2e3 TelepathyLoggerQt4/log-manager.cpp 7aadc4d CMakeLists.txt db1da08 TelepathyLoggerQt4/log-manager.h 60a0e8c Diff: https://git.reviewboard.kde.org/r/119085/diff/ Testing ------- Thanks, Marcin Ziemiński
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
