> On Feb. 29, 2016, 7:45 p.m., Martin Klapetek wrote: > > KTp/global-presence.cpp, lines 364-374 > > <https://git.reviewboard.kde.org/r/123482/diff/2/?file=445121#file445121line364> > > > > Same as above, set the var directly and break.
The simplification for this matching isChangingPresence was reverted in the latest patch; the Connecting... state can be valid for a single account with the rest Connected, while Connecting should be the global connection state. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123482/#review92927 ----------------------------------------------------------- On April 27, 2016, 8:20 p.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123482/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 8:20 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > New classes: > -StatusHandlerPresence, an interface for StatusHandler PluginQueue and > AccountStatusHelper DBus interfaces, and a number of control functions for > the Presence / StatusMessageInserter plugins (per-app save / restore presence > replacement). > > New properties: > -GlobalPresence: bool activeAutoPresence(), bool mixedPresenceMode(), > KTp::Presence globalRequestedPresence(). > > New methods: > -GlobalPresence: onAccountDisabled(Tp::AccountPtr) > > New types: > KTp::PluginQueue, for indicating the state of the plugin queue plugins, e.g. > PluginDisabledOnLoad, PluginDisabled, PluginEnabled, PluginActive, etc. > > New features: > -pluginQueue active / inactive information in GlobalPresence, separate > presenceQueueActiveChanged and statusMessageQueueActiveChanged signals. > -More reliable global property signalling. > -Reworked account enable / disable. > -Presence priority improvements. > > Other simple cleanups (Use KTp::Presence where possible, make function > arguments conform, commenting clarifications, errant properties, etc.) > > > Diffs > ----- > > KTp/CMakeLists.txt 85d578bc3cbc0ae5769e6ff9f466381da4e701a7 > KTp/Declarative/qml-plugins.cpp 4956a1c94fe60a526367f6a74a357d510e74e519 > KTp/Models/presence-model.cpp ddc1a7c75f1a452bf3ac2db1aecbd88a5d1ce519 > KTp/global-presence.h 46e6cc358b0f3cdaff35d3a7be25949646b400d3 > KTp/global-presence.cpp 8f1148b4ec339ab77f9c2fca0c87429ac14c5194 > KTp/presence.h 7da07d0120c75ed057f4b2f2f832f5a1f80bd528 > KTp/presence.cpp 6030db0ed821a4399603b5453ab124c741912a1f > KTp/status-handler-presence.h PRE-CREATION > KTp/status-handler-presence.cpp PRE-CREATION > KTp/types.h 27eb8975a4149e78c1e545b7273572c7eb18bad3 > > Diff: https://git.reviewboard.kde.org/r/123482/diff/ > > > Testing > ------- > > Compile, run. > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
