----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123482/ -----------------------------------------------------------
(Updated Jan. 10, 2017, 4:26 p.m.) Review request for Telepathy and David Edmundson. Changes ------- Rebase. 1) ConnectionPresenceType and PluginState Q_ENUMS -> Q_ENUM. Repository: ktp-common-internals Description (updated) ------- New classes: -StatusHandlerPresence, an interface for StatusHandler PluginQueue and AccountStatusHelper DBus interfaces, and a number of control functions for the Presence / StatusMessageInserter plugins (per-app save / restore presence replacement). New properties: -GlobalPresence: bool activeAutoPresence(), bool mixedPresenceMode(), KTp::Presence globalRequestedPresence(). New methods: -GlobalPresence: onAccountEnabledChanged(Tp::AccountPtr) replaces onAccountEnabled(Tp::AccountPtr). New types: KTp::PluginQueue, for indicating the state of the plugin queue plugins, e.g. PluginDisabledOnLoad, PluginDisabled, PluginEnabled, PluginActive, etc. New features: -pluginQueue active / inactive information in GlobalPresence, separate presenceQueueActiveChanged and statusMessageQueueActiveChanged signals. -More reliable global property signalling. -Reworked account enable / disable. Other simple cleanups (Use KTp::Presence where possible, make function arguments conform, commenting clarifications, errant properties, etc.) Diffs (updated) ----- KTp/CMakeLists.txt 85d578bc3cbc0ae5769e6ff9f466381da4e701a7 KTp/Declarative/qml-plugins.cpp 27ed202be547c088feaba92664b64617e3e541fc KTp/global-presence.h 46e6cc358b0f3cdaff35d3a7be25949646b400d3 KTp/global-presence.cpp 0b751b145a227d59de564baa21bed1df0b23b125 KTp/status-handler-presence.h PRE-CREATION KTp/status-handler-presence.cpp PRE-CREATION KTp/types.h 8d3ca4fc14a37b61abecdf78594f334f7b6aa797 Diff: https://git.reviewboard.kde.org/r/123482/diff/ Testing ------- Compile, run. Thanks, James Smith
