On Fri, 2008-10-31 at 12:19 -0500, Nicolas Williams wrote: > On Fri, Oct 31, 2008 at 06:13:47PM +0100, Mark Phalan wrote: > > On Fri, 2008-10-31 at 12:03 -0500, Nicolas Williams wrote: > > > I don't understand why you changed the function signature for > > > ss_parse(). The only place it's called the return value is now ignored, > > > so that distinguishing between "nothing entered" and "error" is not > > > really done. > > > > Its called twice: > > > > listen.c:97 (where the return value is checked) > > > > and > > > > execute_cmd.c:216 (where it isn't). > > I'm blind. Thanks. > > (You could have kept it the way it was, and set errno = 0 prior to > calling it, and checked errno after calling it if it returned NULL, but > I don't care.)
Can I take it that you've reviewed the changes and are happy with them (at least for the libtelca support)? -M
