Nice catch on that cause 670b0872ad88 ("UBUNTU: SAUCE: selftests:
Skip BPF seftests by default"), in which we make the bpf subset as
a default skip target by default. (This explained why this works in comment #13)

I prefer to keep TARGETS=bpf and add an empty SKIP_TARGETS= to the
make command to override the default value, so that we can still
align with how we start a kernel-selftests subset (like in the
ubuntu_kernel_selftests).

e.g.
utils.make('-C linux/tools/testing/selftests TARGETS=bpf SKIP_TARGETS= clean 
all')

A SKIP_TARGETS= might be helpful for pepole to know this is for
overriding the default value as well.

Thanks
Sam

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1917609

Title:
  [Regression] ubuntu_bpf failed to build on Groovy

Status in ubuntu-kernel-tests:
  In Progress
Status in linux package in Ubuntu:
  Invalid
Status in linux source package in Groovy:
  Fix Committed

Bug description:
  [Impact]
  Upstream commit d3bec0138bfbe58606fc1d6f57a4cdc1a20218db (bpf: Zero-fill 
re-used per-cpu map element) was applied to Groovy as part of an upstream 
stable update. This patch fixes a bpf issue and at the same time adds new 
selftests to verify these changes. However, the selftests can't be compiled on 
5.8 due to missing helper functions that were added only later. The bpf 
selftest build fails with errors such as:

  /usr/bin/ld: 
/tmp/autopkgtest.IzBxE1/build.8NX/src/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/bpf/map_init.test.o:
 in function `prog_run_insert_elem':
    
/tmp/autopkgtest.IzBxE1/build.8NX/src/autotest/client/tmp/ubuntu_kernel_selftests/src/linux/tools/testing/selftests/bpf/prog_tests/map_init.c:89:
 undefined reference to `ASSERT_OK'

  [Fix]
  The proposed fix it to partially revert this commit by removing the selftests 
parts.

  [Testcase]
  On a groovy/linux repo:

  $ make -C tools/testing/selftests TARGETS=bpf SKIP_TARGETS=

  [Where problems could occur]
  By removing the selftests we could be introducing a regression with the bpf 
code change which would be likely unoticed during the tests.

  
  ==== Original Description ====

  Issue found on 5.8.0-1024.26-azure / 5.8.0-1022.23-oracle

  Test failed to build, I didn't see any meaningful error message, this
  might need to be double checked.

      HDRINST usr/include/asm/fcntl.h
      HDRINST usr/include/asm/termbits.h
      HDRINST usr/include/asm/errno.h
      INSTALL ./usr/include
    make[1]: Leaving directory 
'/home/ubuntu/autotest/client/tmp/ubuntu_bpf/src/linux'
    make: Leaving directory 
'/home/ubuntu/autotest/client/tmp/ubuntu_bpf/src/linux/tools/testing/selftests'
    stderr:
    make: *** [Makefile:159: all] Error 1

  Please find attachment for the complete test log.

  == Process to reproduce this ==
  1. git clone 
git://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/groovy
  2. cd groovy/tools/testing/selftests
  3. make TARGETS=bpf
  You will see the build failed if it's affected by this.

  I think this is affecting the ubuntu_kernel_selftests as well, as the
  net test would require the bpf test to be built first.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1917609/+subscriptions

-- 
Mailing list: https://launchpad.net/~kernel-packages
Post to     : kernel-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kernel-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to