From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1980#note_1067764364
Yes, the solution is to verify a temporary changelog instead of changing/reverting/changing again using the Makefile target hacks: so genlog.py always creates a header (the rpm changelog header for the changes with the author and timestamp) plus a Resolves line, plus a blank line. Thus that's 3 lines and why the check uses wc, so if there is only that, there are no changes, and we use that to check for changes. Also due ark rebases there is also the marker check. I see genlog.sh vs .py might be confusing, but didn't have a better name. Moving all code into python also may not be desirable, the python part does a good job of parsing the git changelog (it replaced the previous awk script we had), but the other stuff seems better to be handled through shell. And yes, genlog.py is only called by genlog.sh. _______________________________________________ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
