I do have one suggestion. Rather than prefix all of the default settings with "default_", why not just create a default section and use tokens without the "default_" prefix. It would be more organized and a bit less verbose. It would also be a useful place to store other default settings.
On 7/3/2019 2:09 PM, Jeff Young wrote: > Hi Seth, > > We could; all this stuff is from 5.1. How is it possible that it's in 5.1 and not in master? > > However, the file format has already changed, and it will change again for > Jon’s changes. So I don’t think it makes any material difference if we > integrate this stuff, and it does clean up loose ends which I hate leaving > lying around. > > Cheers, > Jeff. > >> On 3 Jul 2019, at 18:46, Seth Hillbrand <[email protected]> wrote: >> >> Hi Jeff- >> >> Can we split out the DRC things? I'm pretty sure that these are included in >> Jon's DRC rework, so it would be nice to avoid a temporary file format that >> we supersede shortly. >> >> -S >> >> >> On 2019-07-03 06:23, Jeff Young wrote: >>> Please see >>> https://git.launchpad.net/~jeyjey/kicad/commit/?id=a2c2d9f5d9b37576ec72cd0d4c64652cfddeb8df >>> for board file changes for: >>> 1) min-hole-to-hole distance >>> 2) courtyard DRC flags (require courtyards and prohibit overlapping >>> courtyards) >>> 3) default layer line widths and text dimensions >>> Cheers, >>> Jeff. >>>> On 2 Jul 2019, at 16:58, Wayne Stambaugh <[email protected]> >>>> wrote: >>>> On 7/2/2019 11:11 AM, jp charras wrote: >>>> Le 02/07/2019 à 16:55, Jeff Young a écrit : >>>> I was testing 5.1 and noticed that it can no longer open 6.0 files. >>>> Was this accidental, or have we now diverged? >>>> (I ask only because I have a bunch of fixes waiting for file format >>>> changes which I could go ahead and make if we have officially >>>> diverged.) >>>> Cheers, >>>> Jeff. >>>> There is at least a change: "max_error" param in "setup" section. >>>> I have myself some other changes waiting in file format to support >>>> zones >>>> filled without outline thickness, and a support for board stackup >>>> info >>>> (for manufacturing purposes) >>> Since the board file format in the master branch is no longer >>> compatible >>> with the 5.1 branch, I don't see any issues with pushing file format >>> changes. I only ask that before you push commits that affect the file >>> format, please post your changes so we can take a look at them so we >>> can >>> review the file format changes before we merge them. Please be sure >>> to >>> keep the file version up to date correctly as you push your individual >>> changes to prevent any user issues. >>> Cheers, >>> Wayne >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : [email protected] >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp > _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : [email protected] Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
