----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112364/#review40732 -----------------------------------------------------------
I would not ship this patch. I'll elaborate a bit more my comments at https://bugs.kde.org/show_bug.cgi?id=312816#c6 and I'll base my arguments on this recording I made http://kmymoney2.sourceforge.net/screencasts/112364.ogv about how this patch behaves. 1. It breaks with the current behavior of the application (auto resizing columns after data has been entered to fit the entered data) 2. It introduces bugs, I mean, setting a maxWidth of "9,999,999.00 " for the amount fields!? This is exactly what was hurting the number column and the fix should be all about removing a limitation not adding new ones - Cristian Oneț On Sept. 15, 2013, 4:26 p.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112364/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2013, 4:26 p.m.) > > > Review request for KMymoney. > > > Description > ------- > > If I choose to use a complex system for check numbers, such that the whole > number is not visible, > the only way I have available is to stretch the whole window. However, even > that doesn't help, > as the whole of the increase is grabbed by the Details column. I accept that > it is likely that that > column is going to need to be the widest. Then, why are the Payment and > Deposit columns twice the > width of the Balance column, when that column may be likely to have the > greatest value? Ditto for > the Date. > > This fix allows modification of column widths, but also resizes the > individual columns to more suitable widths. > > I found that Thomas had started to implement something similar some while > ago, so I have built upon and expanded that. > > I found that the edit widgets were particularly troublesome, in failing to > appear/disappear with the show() and hide() > methods, which I'd previously found when last in this area. Then, when the > screen was being resized, they flickered > more than acceptable. Eventually, where necessary, I resorted to > zeroing/resetting the height instead, which resolved > the issue, although with some complication. > > > This addresses bugs 312816 and 322768. > http://bugs.kde.org/show_bug.cgi?id=312816 > http://bugs.kde.org/show_bug.cgi?id=322768 > > > Diffs > ----- > > kmymoney/dialogs/transactioneditor.h f07dafb > kmymoney/dialogs/transactioneditor.cpp 39049cf > kmymoney/views/kgloballedgerview.cpp 2057b47 > kmymoney/widgets/register.h eebe78d > kmymoney/widgets/register.cpp 1bdf5bd > > Diff: http://git.reviewboard.kde.org/r/112364/diff/ > > > Testing > ------- > > Extensive editing of sample files, and changing back and forth between > different activity types, which tended to show > problem areas. atype run. > > > Thanks, > > Allan Anderson > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
