-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112947/
-----------------------------------------------------------
(Updated Oct. 3, 2013, 10:23 a.m.)
Status
------
This change has been marked as submitted.
Review request for KMymoney.
Bugs: 322768
http://bugs.kde.org/show_bug.cgi?id=322768
Repository: kmymoney
Description
-------
- Interest category disappears -
Steps to Reproduce:
1.Open a new Dividend transaction.
2.Enter an interest category and amount.
3.Enter a new fee category.
4.On accepting the new category, the interest category and amount have been
cleared.
One line fix in kmymoney/dialogs/transactioneditor.cpp.
- Fixes for KEditWidget visibility issues.
When editing an investment transaction, interest or fee edit widgets show or
hide incorrectly. This is a fairly long-standing issue, and there have been
attempts to fix by delaying the show() or hide() instructions. This became
more pronounced during work to allow column resizing, and Cristian produced a
fix for the root cause. This fix is included here.
With the above fix in place, it became necessary to revert the delayed show()
and hide() calls, and this has been done.
Of course, nothing is ever as simple as that, and another couple of issues
emerged. Whether or not an interest or fee amount widget is shown depends on
the presence or absence of the associated category's text. It transpired that
if, say, an existing Reinvest transaction was edited to be, say a Buy
transaction, the text from the Reinvest interest category was seen by the new
Buy entry and resulted in the interest-amount widget being visible when none
should appear. Similarly, if a transaction with a fee set is edited to be a
type with no fee expected, for instance, an Add or RemoveShares, then the
fee-amount widget became visible when not needed.
It was necessary to rework the slotUpdateFeeVisibility() and
slotUpdateInterestVisibility() functions to take account of the new transaction
type.
Diffs
-----
kmymoney/dialogs/investactivities.cpp 50f33ed
kmymoney/dialogs/investtransactioneditor.h 3e62c2a
kmymoney/dialogs/investtransactioneditor.cpp e9f87fb
kmymoney/dialogs/transactioneditor.cpp cfb0f71
kmymoney/widgets/transactioneditorcontainer.h f77b195
Diff: http://git.reviewboard.kde.org/r/112947/diff/
Testing
-------
Entering and editing various transaction types to ensure only the appropriate
widgets became visible or hidden when required.
Thanks,
Allan Anderson
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
