----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127559/#review94397 -----------------------------------------------------------
I withdraw my last comment. I did not see that ```m_buy...``` had an ```if``` already. Sorry for more confusion than help :/ kmymoney/plugins/csvimport/investprocessing.cpp (line 1967) <https://git.reviewboard.kde.org/r/127559/#comment64175> Should become ```m_shrsinList = profilesGroup.readEntry("ShrsinParam", m_shrsinList);``` The if() is very long and not needed here. However, I still do not know if this is the issue. Also the ```i18nc()s``` from ```init()``` could go here if the readSettings method is always called, which I do not know either. - Christian David On April 3, 2016, 6:45 a.m., Łukasz Wojniłowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127559/ > ----------------------------------------------------------- > > (Updated April 3, 2016, 6:45 a.m.) > > > Review request for KMymoney. > > > Bugs: 360129 > http://bugs.kde.org/show_bug.cgi?id=360129 > > > Repository: kmymoney > > > Description > ------- > > Fixes bug #360129. During creation of new investment statement > template, transaction types are initialized in > investprocessing.cpp, but then are overridden with empty fields > from profile that was just created in csvimporterrc which results > in every non-buy transaction unrecognized during the import. > > > Diffs > ----- > > kmymoney/plugins/csvimport/investprocessing.cpp 3879819 > > Diff: https://git.reviewboard.kde.org/r/127559/diff/ > > > Testing > ------- > > Tested using financial statement from bug #360129. > > > Thanks, > > Łukasz Wojniłowicz > >