> On April 7, 2016, 7:59 p.m., Christian David wrote:
> > kmymoney/plugins/csvimport/investprocessing.cpp, line 1967
> > <https://git.reviewboard.kde.org/r/127559/diff/1/?file=455181#file455181line1967>
> >
> > Should become
> > ```m_shrsinList = profilesGroup.readEntry("ShrsinParam",
> > m_shrsinList);```
> >
> > The if() is very long and not needed here. However, I still do not know
> > if this is the issue. Also the ```i18nc()s``` from ```init()``` could go
> > here if the readSettings method is always called, which I do not know
> > either.
>
> Allan Anderson wrote:
> > Should become
> > m_shrsinList = profilesGroup.readEntry("ShrsinParam", m_shrsinList);
>
> I'm not sure I understand this. The second parameter is the default
> value to return if the key is not found. What does it achieve in this case?
>
> > The if() is very long and not needed here.
>
> There are several ifs around here, but I don't see an unduly long one.
>
> > Also the i18nc()s from init()
> > could go here if the readSettings method is always called, which I do
> not know either.
>
> readSettings is called only once, from void
> InvestProcessing::slotFileDialogClicked(), so that code could be moved
> somewhere in void InvestProcessing::readSettings(), I think.
> Should become
> m_shrsinList = profilesGroup.readEntry("ShrsinParam", m_shrsinList);
I compiled KMyMoney code according to your change for every m_XXXList variable
and ran my test case. Proposed line looks neat but doesn't work for me.
SellParam= etc. are empty in my csvimporterrc after just created new profile.
>readSettings is called only once, from void
>InvestProcessing::slotFileDialogClicked(), so that code could be moved
>somewhere in void InvestProcessing::readSettings(), I think.
Please give a code and I'll test it.
> I do not know the full conversation but I am pretty sure this patch will not
> solve the issue. If something in the newly created rc file is missing, the
> write method seems to fail, not the read method.
My loose observation: Write method is called at the end of importing and read
method is called after creating new importing profile for investment.
- Łukasz
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127559/#review94397
-----------------------------------------------------------
On April 3, 2016, 4:45 a.m., Łukasz Wojniłowicz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127559/
> -----------------------------------------------------------
>
> (Updated April 3, 2016, 4:45 a.m.)
>
>
> Review request for KMymoney.
>
>
> Bugs: 360129
> http://bugs.kde.org/show_bug.cgi?id=360129
>
>
> Repository: kmymoney
>
>
> Description
> -------
>
> Fixes bug #360129. During creation of new investment statement
> template, transaction types are initialized in
> investprocessing.cpp, but then are overridden with empty fields
> from profile that was just created in csvimporterrc which results
> in every non-buy transaction unrecognized during the import.
>
>
> Diffs
> -----
>
> kmymoney/plugins/csvimport/investprocessing.cpp 3879819
>
> Diff: https://git.reviewboard.kde.org/r/127559/diff/
>
>
> Testing
> -------
>
> Tested using financial statement from bug #360129.
>
>
> Thanks,
>
> Łukasz Wojniłowicz
>
>
