http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414
M. de Rooy <m.de.r...@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from M. de Rooy <m.de.r...@rijksmuseum.nl> --- QA Comment: Thanks for sending your patch. I have been thinking about your patch a while. But in the end it seems to me that we should not be mixing the features ranking and truncation in one syspref. Search.pm is already hard to maintain. A crucial piece of your code: - $weighted_query .= " or wrdl,r9=\"$operand\""; - + } elsif ( $weight_fields == 2 ) { + $weighted_query .= " or wrdl,right-Truncation,r9=\"$operand\""; + } else { + $weighted_query .= " or wrdl,r9=\"$operand\""; Question: Could you think of another way to determine when we want right truncation in the deleted first line? Do we really need an adjusted pref? Since this is a complicated patch (changing Search.pm), I would also like a thorough test plan. There is no test plan now. And I would appreciate to hear from the one who signed off: What did you exactly test? Small stuff: [1] Add type choice in the pref file. [2] There is no print statement in the db rev. Moving this to Failed QA for now. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/