http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368
--- Comment #7 from Kyle M Hall <k...@bywatersolutions.com> --- > 0) The QA script fails: > > FAIL misc/migration_tools/import_lexile.pl > FAIL critic > I/O layer ":utf8" used at line 39, column 1. Use > ":encoding(UTF-8)" to get > strict validation. > FAIL forbidden patterns > forbidden pattern: Koha is now under the GPLv3 license (line 9) > OK pod > OK valid Will fix! > 1) Is copyright 2013 correct? Will fix! > > 2) I am not sure what one of the options means from the description, could > you clarify? > + --source-value Defines the value to put stored in the "Source" > subfield ( default: "Lexile" ) Please take a look at http://www.loc.gov/marc/bibliographic/bd521.html Basically, 521 fields can store all types of target audience data. 521$a stores the 'rating' while 521$b stores the type of the rating. In this case, the rating is a Lexile score. > 3) The documentation for --file says: "acquired from Lexile.com", but the > actual file format is not documented. I think maybe we need to decide here > if this is a vendor specific or a general purpose script. If it's vendor > specific, we might want to reflect that more clearly in the file name and > description. If it's general purpose, we should include notes about the file > format to make this easier to reuse. I'll add the file format to the help. This is meant specifically for importing Lexile.com files ( as they own and control Lexile rankings ) but this script is general purpose enough to import any CSV file that matches the schema. > > 4) We didn't really finish our discussions about the standard options for > CLI scripts > (http://wiki.koha-community.org/wiki/Coding_Guidelines#Command- > line_argument_conventions), but maybe this should have a -c for confirming > the action as it's going to change data? I'll add the -c and -t options. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/