[Koha-bugs] [Bug 14518] New: Deleting notices with reservations (and no item) does not work

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518

            Bug ID: 14518
           Summary: Deleting notices with reservations (and no item) does
                    not work
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcha...@gmail.com
          Reporter: philippe.blo...@inlibro.com
        QA Contact: testo...@bugs.koha-community.org
                CC: m.de.r...@rijksmuseum.nl

There's a popup asking for confirmation, but the Yes is ignored.

The change to the code is very simple.  In
intranet-tmpl/prog/en/includes/cat-toolbar.inc:

54         else if ( holdcount > 0 ) {
55             is_confirmed = confirm( _("%s holds(s) for this ...
56         } else {
57             is_confirmed = confirm(_("Are you sure you want ...
58         }
59         if (is_confirmed) {
60             if ( count > 0 || holdcount > 0 ){    <<== but we just
confirmed!!
61                 return false;                     <<== Nooooooo!!!
62             } else {
63                
window.location="/cgi-bin/koha/cataloguing/addbiblio.pl?op=delete&amp;biblionumber=[%
biblionumber %]";
64             }

Our proposed fix is just to remove that extra if.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/