http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #51 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org> --- Comment on attachment 46279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46279 Bug 10612 - Add ability to delete patrons with batch patron deletion tool Review of attachment 46279: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10612&attachment=46279) ----------------------------------------------------------------- ::: tools/cleanborrowers.pl @@ +85,5 @@ > > + my $patrons_to_delete; > + if ($patron_list_id) { > + my @patron_list_patrons = > + Koha::Database->new()->schema()->resultset('PatronListPatron') It would be better to use Koha::List::Patron instead. @@ +169,5 @@ > trash => ( $radio eq "trash" ) ? (1) : (0), > testrun => ( $radio eq "testrun" ) ? 1: 0, > ); > +} else { # $step == 1 > + $template->param( patron_lists => [ GetPatronLists() ] ); I'd make more sense to pass the non empty patron lists only. @@ +185,4 @@ > #writing the template > output_html_with_http_headers $cgi, $cookie, $template->output; > > +sub _skip_borrowers_with_nonzero_balance_or_issues { You are modifying the behavior of the tool. This change should be moved to another bug report (misc/cronjobs/delete_patrons.pl will need the change too). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/