http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167
M. de Rooy <m.de.r...@rijksmuseum.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #75 from M. de Rooy <m.de.r...@rijksmuseum.nl> ---
QA Comment:
Jonathan: I am very sorry, but I fear that you missed my main point somehow
from comment70 /comment71 about the distinction between numbered and unnumbered
dbrevs. Please reread. Just in short: In user mode installer should run the
numbered dbrevs; the update form only lists both dbrevs for reference. There is
no need to run dbrevs from there in that mode.
In dev mode installer still runs the numbered dbrevs, the update form allows
you to run the other ones in any order.
The current patch still allows me to run both groups. (And I still think that
you can make this adjustment without changing too much..)
Secondly, see my comment on Mainpage AND Authorization. Please move the
extended version check back from mainpage to checkauth but later in time (only
for new sessions). Note also that the double login problem still remains. After
applying your patch, and installing the new cpan module, I had to login twice
again. (See the cookie comment?)
File structure: Paul is right. I meant subdirs per version. Note that I did not
mean creating the files for 001 to 018. Since they are in updatedatabase
already, I would suggest to remove them from this patch (*sorry*).
Upgrading: You wrote:
> I don't know how I can do this simply and properly. if someone feels
> motivated...
This point is closely related to the first comment. Please look at install.pl
around line 324. We need to record the exact dbrev when this patch is pushed,
and compare against that. If we are lower, run first old updatedatabase. And
after that, make a call to your new code to run the numbered dbrevs in the
versions dir(s). I am convinced that you can do that very well and properly :-)
See also my earlier comment on Stable version. This needs some additional
precaution, since we will not implement it in master and 3.8.X at the same
time. (The version compare in 3.8.X will be different from master.) When
upgrading to 3.10, you cannot completely prevent running some dbrevs for a
second time. (But some could be skipped when comparing your checksums between
3.8 and 3.9 folder.) This issue will reappear at every new version (e.g.
comparing checksums again between 3.10 and 3.11 folder, etc.)
New (minor) point: C4/Update/Database: New dependency introduced: Can't locate
File/Find/Rule.pm in @INC. Do you really need this one? You only need to get
some file names? Just use glob?
Hope that this helps.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
