http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688
Paul Poulain <paul.poul...@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Paul Poulain <paul.poul...@biblibre.com> --- QA comment: * this path is huge, but most of it's size is due to sample files in various language. Well done, even if they are not all translated. Will call for more translation when pushing * passing our QA script says: 1st problem = # Subroutines::ProhibitExplicitReturnUndef: Got 1 violation(s). I see that there is + return undef unless $subscriptionid; in GetSubscriptionIrregularities Should be + return unless $subscriptionid; 2nd problem = - xt/tt_valid.t tests... FAIL intranet-tmpl/prog/en/modules/serials/subscription-add.tt: 656, 666, 687 FAIL Those lines contain a construction that is still invalid (despite joubu effort): <option value="[% frequency.id %]" [% IF (frequency.selected) %] selected="selected" [% END %]> <option value="[% subt.name %]" [% IF (subt.selected) %] selected="selected" [% END %] > <option value="[% numberpattern.id %]" [% IF (numberpattern.selected) %] selected="selected" [% END %]>[% numberpattern.label %]</option> My git hook says nothing wrong. This patch will earn "passed QA" once the 2 previous problems have been fixed. Also note that there is a conflict easy to solve in C4/Serials.pm I've added a sub in bug 7839, just keep it, with your own ones (beware the closing } for subs !) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/