https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #72 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- Having a look here too. Database update and permissions look good. Seems to work well, although I have some concerns about macros working correctly in our current version (see 5) Found only some small stuff that needs fixing: 1) QA test tool fail FAIL Koha/AdvancedEditorMacros.pm FAIL pod coverage POD is missing for 'object_class' OK spelling 2) Translatability Jonathan, I think you are right, if these show in the GUI (which it looks like) they won't be translatable. openapi => { error => "To create shared macros you must use advancededitor/shared" } ); openapi => { error => "To create private macros you must use advancededitor" } ); There are also some other glitches in the Javascript code: + $convert = $( '<button class="btn btn-default" id="convert-macros" title="Convert browser storage macros"><i class="fa fa-adjust"></i> Convert old macros</button>' ); 3) Should these API additions be voted on? 4) Capitalization I've noticed lots of glitches there in patches recently - makes my inner librarian unhappy: + "description": "Advanced Editor Macro internal identifier", 5) Testing went well, but I am wondering if there is an issue with our MACRO language. A lot of the examples I tried from the wiki would not work: https://wiki.koha-community.org/wiki/Advanced_editor_macros Especially the RDA macros that add multiple subfields - only the first subfield code will be recognized. I assume they used to work (trusting Heather), so what happened there? As this is so heavy on API it would be nice to get Tomas to have a look too. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/