https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268
Tomás Cohen Arazi <tomasco...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |agustinmoy...@theke.io,
| |martin.renvoize@ptfs-europe
| |.com
--- Comment #74 from Tomás Cohen Arazi <tomasco...@gmail.com> ---
The fact it relies on the API should be a good thing for everyone, no one wants
to add new CGI controller scripts that can only be tested with selenium :-D
About translatability, the JS libraries usually just detect faulty codes (4XX,
5XX, and so on). And the error message is not what gets presented to the end
user. That should be handled as usual in JS with translatability in mind. For
example, if we do
GET /a/resource/12
and get a 404, it doesn't matter the JSON that is returned (even though we try
to be consistent on the format and texts there). The code on the UI should
handle the fact that the requested resource doesn't exist, based on the 404
code.
That said, maybe Nick relied on those messages for the UI, and that should be
fixed. I haven't checked that myself.
Regarding the need for a vote, I'd say we should, yes. This patchset requires
something different than others: the resources (macros) can belong to a patron,
but can also be shared. And we can only specify AND conditions for resource
access. So we cannot say (on the spec) things like: 'you can edit this if you
are superlibrarian or the owner'. It could be worked out in a different way,
but I don't think we can avoid (at least) a minimum check in the controller,
and is just fine IMHO.
I will recheck this patchset in deep and provide more feedback ASAP. Specially
if some design change can make this cleaner to implement. I haven't found a
better option, thus adding Martin and Agustin to the conversation to gather
more ideas.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
