https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106417|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- Created attachment 107373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107373&action=edit Bug 25724: Do not call ModReserveStatus when completing transfer I can not see how this code is useful here. It checks for a reserve with priority 0 and found = NULL That is not a status that should occur when filling a transfer. Either the found is 'T' if we are transferring due to the hold, or the hold was placed after the transfer was initiated, and so the priority is not 0 Additional, AddReturn checks for reserves later and asks the staff to confirm waiting status. ModReserveStatus also calls CartToShelf regardless of what happens here. To test: 1 - Set UpdateItemLocationOnCheckin to: _ALL_: CART 2 - SetAutomaticItemReturn = Do 3 - Check an item in at a different branch than it's homebranch to create a transfer 4 - Check the item in at it's homebranch 5 - View the item details page 6 - Item is not in CART location 7 - Apply patch 8 - Repeat 9 - Item is in CART location after completion of transfer Signed-off-by: Andrew Fuerste-Henry <and...@bywatersolutions.com> Signed-off-by: Jason Robb <jr...@sekls.org> Signed-off-by: Katrin Fischer <katrin.fischer...@web.de> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/